Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Koin upgrade followup #243

Merged
merged 6 commits into from
Jan 3, 2025
Merged

Chore: Koin upgrade followup #243

merged 6 commits into from
Jan 3, 2025

Conversation

FelberMartin
Copy link
Collaborator

Problem Description

There were still a few follow-ups after #135, these are tackled here.

Changes

  • Using new koin verify() method to verify module initialization
  • Removing now no longer needed workaround to use koin in tests (LocalKoinScope, LocalKoinApplication)

Steps for testing

  • See that all tests still pass

@FelberMartin FelberMartin self-assigned this Dec 20, 2024
@FelberMartin FelberMartin added the ready for review This PR can be reviewed label Dec 20, 2024
julian-wls
julian-wls approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@julian-wls julian-wls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm!

@FelberMartin FelberMartin added ready to merge This PR can be merged and removed ready for review This PR can be reviewed labels Jan 3, 2025
@FelberMartin FelberMartin merged commit 512705c into develop Jan 3, 2025
5 checks passed
@FelberMartin FelberMartin deleted the chore/koin-upgrade-followup branch January 3, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-wls julian-wls julian-wls approved these changes

Assignees

@FelberMartin FelberMartin

Labels
ready to merge This PR can be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FelberMartin @julian-wls